Skip to content

feat(php): Add all config classes generation #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2022
Merged

feat(php): Add all config classes generation #730

merged 4 commits into from
Jun 22, 2022

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jun 22, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-525

Changes included:

  • Add generation of all {CLIENT]Config.php classes
  • Add generation of ConfigWithRegion.php class
  • Remove possibility to commit directly those classes

🧪 Test

CI

@damcou damcou requested review from millotp and shortcuts June 22, 2022 13:11
@damcou damcou self-assigned this Jun 22, 2022
@netlify
Copy link

netlify bot commented Jun 22, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit bedcd44
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62b31a3a3327ca00090aacd5

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 22, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :) small comment

@damcou damcou requested a review from shortcuts June 22, 2022 13:39
shortcuts
shortcuts approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@damcou damcou merged commit c4d1ccf into main Jun 22, 2022
@damcou damcou deleted the feat/APIC-525/php-config-files-gen branch June 22, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp Awaiting requested review from millotp

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damcou @algolia-bot @shortcuts