fix(scripts): prevent incorrect run conditions #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
feat/javascript-nested-algoliasearch-lite
branch
2 times, most recently
from
28b800a to
653ccb0
Compare
shortcuts
force-pushed
the
fix/run-condition-cli
branch
2 times, most recently
from
3ff8806 to
d960c98
Compare
Base automatically changed from
feat/javascript-nested-algoliasearch-lite
to
main
June 22, 2022 14:20
shortcuts
force-pushed
the
fix/run-condition-cli
branch
from
d960c98 to
1ebfdb4
Compare
shortcuts
changed the title
shortcuts
force-pushed
the
fix/run-condition-cli
branch
from
1ebfdb4 to
37eb338
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
millotp
reviewed
Jun 23, 2022
| .filter(Boolean); | ||
| } | ||
|
|
||
| export async function prompt({ |
There was a problem hiding this comment.
I'm not sure if anyone will ever use this feature ahah, I did it for fun but it should not become a pain to maintain
There was a problem hiding this comment.
I sometimes do when I'm lazy to type things D:
millotp
reviewed
Jun 23, 2022
oopsie 06fb7c0 |
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
There was some combination that we could execute in our CLI that were not possible (
javaalgoliasearch,phplite, etc.) due to the special JavaScript cases.We now restrict those usage to avoid unwanted behaviors.
Other changes in this PR
flagsandargumentsusage to avoid duplicate informations at command levelindex.ts.to aclifolder to ease folder structure🧪 Test