feat(php): Remove file cache driver for PHP #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
I also think we can remove it from the generated client if you did not find more recent motivations to keep it. We should however state it in the language specific breaking change section, like we did for the |
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jun 22, 2022
algolia/api-clients-automation#733 Co-authored-by: Damien Couchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-526
Changes included:
In one of the last review, @millotp asked to investigate the
FileCacheDriver.phpfile, which is not used in the client.I checked on the current PHP client repository and the file is not used as well, I did some investigation and I found a discussion (from 2018) regarding the file in the corresponding PR : https://github.com/algolia/algoliasearch-client-php/pull/439/files#diff-6290414006afe1d93e90475ab1e1946e34b974e9907eb0a251ad43261058bf89
I'm pretty ok with not keeping the file since we'll have to maintain it, and we have no idea if it's really used or not. It will also prevent from having support regarding file system permissions issues.
WDYT ?