Skip to content

feat(java): use lowercase for model package #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 5, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-569

Follow Java convention and rename the package querySuggestions to querysuggestions.

Because our cli delete the model folder before generation, we need to specify the name change in the scripts also, it will be removed in the next PR.

Changes included:

  • Rename querySuggestions to querysuggestions

🧪 Test

CI

@millotp millotp self-assigned this Jul 5, 2022
@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit d3f6eb6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62c450f2d8f8c10009afd0d4

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 5, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team July 5, 2022 13:55
@millotp
Copy link
Collaborator Author

millotp commented Jul 5, 2022

don't be fooled by the generated code diff, when doing git checkout generated/feat/java-model-case the folder is correctly renamed.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@millotp millotp merged commit d6ba122 into main Jul 6, 2022
@millotp millotp deleted the feat/java-model-case branch July 6, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants