Skip to content

chore(deps): automate update of java formatter #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2022
Merged

chore(deps): automate update of java formatter #817

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e33e3d5
chore(deps): automate update of java formatter
millotp Jul 12, 2022
b3d34c0
greedy
millotp Jul 12, 2022
4b50a88
revert
millotp Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,35 @@
"\\s\"(?<depName>.*?)\": \"(?<currentValue>.*?)\",?\\s"
],
"datasourceTemplate": "npm"
},
{
"description": "Update the java formatter",
"fileMatch": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fileMatch works with filename only not paths

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear but in some examples they use a real path, I think it's a regex on the entire path, starting from the root directory (example)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I expected too when added the support for mustache files but it was in fact matching filenames 🤔 we can try and see how it goes on Friday I guess!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can check right after merging by checking the box in #532 😉

"Dockerfile",
".github/actions/setup/action.yml"
],
"matchStrings": [
"https://github.com/google/google-java-format/releases/download/v(?<currentValue>.*?)/google-java-format-(?<currentValue>.*?)-all-deps.jar"
],
"depNameTemplate": "google/google-java-format",
"datasourceTemplate": "github-releases"
},
{
"description": "Update java packages in mustache files",
"fileMatch": "build.mustache",
"matchStrings": [
"testImplementation '(?<depName>.*):(?<currentValue>\\d.*?)'"
],
"datasourceTemplate": "maven"
},
{
"description": "Update yarn version (won't work because we need to download the script but gives an alert at least)",
"fileMatch": ".yarnrc.yml",
"matchStrings": [
"yarnPath: .yarn/releases/yarn-(?<currentValue>.*?).cjs"
],
"depNameTemplate": "yarnpkg/berry",
"datasourceTemplate": "github-releases"
}
],
"ignorePaths": [
Expand Down