Skip to content

chore(deps): split regex in two #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022
Merged

chore(deps): split regex in two #821

merged 2 commits into from
Jul 13, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 13, 2022

🧭 What and Why

We can't have the same named capture group twice in a regex, split it in 2.
/ seems to be allowed: doc

@millotp millotp self-assigned this Jul 13, 2022
@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team July 13, 2022 11:54
@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 415252e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ceb2ea034f740009a35b28

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 13, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(hopefully) looks good :)

@millotp millotp requested a review from shortcuts July 13, 2022 11:56
@millotp millotp merged commit d205f09 into main Jul 13, 2022
@millotp millotp deleted the chore/renovate-again branch July 13, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants