Skip to content

fix(ci): prevent deleting all tests, correctly run JS tasks #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix(ci): prevent deleting all tests, correctly run JS tasks #869

merged 1 commit into from
Jul 26, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 26, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-595

Changes included:

  • CI ran all jobs for JavaScript, instead of only the ones that changed
    • see build step running everything instead of algoliasearch search clients
  • We delete all tests before restoring the artifact to avoid having to push deleted changes ourselves, but the path to store was wrong which prevent tests to be restored when they did not changed
    • see generation commit, only search related jobs ran, but all tests except those are deleted, which is wrong.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 26, 2022
@netlify
Copy link

netlify bot commented Jul 26, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 1f7648b
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62dffcc96640790008bb2c12

@shortcuts shortcuts enabled auto-merge (squash) July 26, 2022 14:40
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 26, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts disabled auto-merge July 26, 2022 14:54
@shortcuts shortcuts merged commit 5e7ced1 into main Jul 26, 2022
@shortcuts shortcuts deleted the fix/ci-wrong-deletion branch July 26, 2022 14:54
bodinsamuel
bodinsamuel reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for review 😬

This was referenced Jul 26, 2022
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel bodinsamuel left review comments

@sbellone sbellone Awaiting requested review from sbellone

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @bodinsamuel