feat(php): Restore Guzzle as a suggestion #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Aug 3, 2022
| @@ -0,0 +1,151 @@ | |||
| <?php | |||
There was a problem hiding this comment.
It makes me think that our CTS should include tests for all of the requesters we expose, could you please add a task for it?
There was a problem hiding this comment.
Also for the JS client, I've imported tests from the previous major to ensure it still work properly, do we have tests for this one? It could be a great addition in the meantime of the CTS
There was a problem hiding this comment.
Created task : APIC-607
shortcuts
reviewed
Aug 3, 2022
damcou
changed the title
shortcuts
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-600
Changes included:
OpenAPI default generated client introduced Guzzle as a dependency in the composer file, which is different from the current PHP client where this library is just suggested.
The goal of this PR is to mimic the current behaviour where Guzzle is suggested and where the logic fallbacks on a custom HTTP Client in case Guzzle is not installed on the project.
(PR also contains a fix on the Husky exclusion pattern)
🧪 Test