Skip to content

docs(java): small migration guide #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022
Merged

docs(java): small migration guide #934

merged 2 commits into from
Aug 18, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 17, 2022

🧭 What and Why

🎟 JIRA Ticket: DI-359

Add a small migration guide, I'll add the breaking changes about java version in another PR.

Changes included:

  • Fix the doc to include the generic for java
  • Format some tables

🧪 Test

open netlify

@millotp millotp requested a review from damcou August 17, 2022 14:22
@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit da4838f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62fdf4f6f5713e00094453a0
😎 Deploy Preview https://deploy-preview-934--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 17, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp changed the title doc(java): small migration guide docs(java): small migration guide Aug 17, 2022
@millotp millotp self-assigned this Aug 17, 2022
shortcuts
shortcuts previously approved these changes Aug 17, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -178,12 +178,13 @@ client.saveObject("<YOUR_INDEX_NAME>", body);
SearchMethodParams searchMethodParams = new SearchMethodParams();
SearchQueries requests = new SearchQueries();
requests.setIndexName("<YOUR_INDEX_NAME>");
requests.setQuery("my aloglia ojbect");
requests.setQuery("my aloglia object");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was to highlight that we are typo tolerant ahah

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He didn't even see "aloglia" OMG

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops fixing it

damcou
damcou previously approved these changes Aug 18, 2022
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@millotp millotp dismissed stale reviews from damcou and shortcuts via da4838f August 18, 2022 08:14
@millotp millotp merged commit f1522a3 into main Aug 18, 2022
@millotp millotp deleted the feat/java-migration-guide branch August 18, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants