-
Notifications
You must be signed in to change notification settings - Fork 21
feat(php): add iterator helper methods #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! I didn't test it but if it comes from the previous client there should be no issue :)
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
….com/algolia/api-clients-automation into feat/APIC-599/add-helper-methods-php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
🧭 What and Why
🎟 JIRA Ticket: APIC-599
Changes included:
I know that this is not exactly what was done for the javascript client, but I think it was faster and more efficient to take inspiration of the current PHP client for this task since we have an already working solution (+ the way it's done for js is probably not as friendly for PHP)
SearchClient
in the constructor so we only use the generated methods in the client)browseObjects
,browseRules
andbrowseSynonyms
in theHelper
class, they call the iterators directly.🧪 Test
yarn docker cts run php
yarn docker playground php search