Skip to content

fix(java): freeze snapshot version to 4.0.0 #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix(java): freeze snapshot version to 4.0.0 #955

merged 2 commits into from
Aug 25, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 25, 2022

🧭 What and Why

🎟 JIRA Ticket: DI-373

Freeze the version to 4.0.0 because that's how it's done in Java, and update the changelog

@millotp millotp self-assigned this Aug 25, 2022
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 2ae3e49
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/630774aa918ac60009b008ee

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure about this but we will since at the next release!

@@ -1,34 +1,13 @@
## [4.4.7-SNAPSHOT](https://github.com/algolia/algoliasearch-client-java-2/compare/4.4.6-SNAPSHOT...4.4.7-SNAPSHOT)
## [4.0.0-SNAPSHOT](https://github.com/algolia/algoliasearch-client-java-2/next)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe java changelog should compare commits not tags 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the tags are not working, using commits is a good idea

@millotp millotp merged commit a54e901 into main Aug 25, 2022
@millotp millotp deleted the fix/java-version branch August 25, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants