fix(cts): friendly error message when test is missing #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
damcou and
shortcuts
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
reviewed
Aug 30, 2022
| @@ -54,7 +54,16 @@ public void run(Map<String, CodegenModel> models, Map<String, CodegenOperation> | |||
| for (Map.Entry<String, CodegenOperation> entry : operations.entrySet()) { | |||
| String operationId = entry.getKey(); | |||
| if (!cts.containsKey(operationId)) { | |||
| throw new CTSException("operationId " + operationId + " does not exist in the spec"); | |||
| throw new CTSException( | |||
There was a problem hiding this comment.
can we add a newline with a link to the doc? https://api-clients-automation.netlify.app/docs/contributing/testing/common-test-suite
There was a problem hiding this comment.
good idea, should be good
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
force-pushed
the
fix/cts-message
branch
from
50d902c to
a24d744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
When a new method is added to the spec, we check that there is a corresponding request test, but the error message was backward.
Now it's:
operationId 'getMachin' does not exist in the tests suite, please create the file 'tests/CTS/methods/requests/client/getMachin.json'🧪 Test
Remove a test from the CTS