Skip to content

fix(specs): remove unretrievableAttributes from searchParams #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(specs): remove unretrievableAttributes from searchParams #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ Read the guides and requirements to:

Test the generated clients by running:

- The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground.md))
- The [`Common Test Suite`](./tests/) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/common-test-suite.md)).
- The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it was an error in purpose @shortcuts ? 🙇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good catch ty :)

- The [`Common Test Suite`](./tests/) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/common-test-suite)).

For full documentation, visit the **[online documentation](https://api-clients-automation.netlify.app/docs/contributing/introduction)**.

Expand Down
16 changes: 8 additions & 8 deletions specs/common/schemas/IndexSettings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ baseIndexSettings:
type: integer
description: Set the maximum number of hits accessible via pagination.
default: 1000
unretrievableAttributes:
type: array
items:
type: string
description: List of attributes that can't be retrieved at query time.
default: []
x-categories:
- Attributes
disableTypoToleranceOnWords:
type: array
items:
Expand Down Expand Up @@ -117,14 +125,6 @@ indexSettingsAsSearchParams:
default: []
x-categories:
- Faceting
unretrievableAttributes:
type: array
items:
type: string
description: List of attributes that can't be retrieved at query time.
default: []
x-categories:
- Attributes
attributesToRetrieve:
type: array
items:
Expand Down
6 changes: 0 additions & 6 deletions tests/CTS/methods/requests/search/search.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,6 @@
"attributesForFaceting": [
""
],
"unretrievableAttributes": [
""
],
"attributesToRetrieve": [
""
],
Expand Down Expand Up @@ -514,9 +511,6 @@
"attributesForFaceting": [
""
],
"unretrievableAttributes": [
""
],
"attributesToRetrieve": [
""
],
Expand Down