Skip to content

[pull] master from conventional-changelog:master #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 25, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

dependabot bot and others added 2 commits June 24, 2023 10:42
Bumps [semver](https://github.com/npm/node-semver) from 7.5.0 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.5.0...v7.5.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@restack-app
Copy link

restack-app bot commented Jun 25, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@instapr
Copy link

instapr bot commented Jun 25, 2023

Thank you for submitting this pull request! Overall, the changes look good to me. I have a few minor suggestions for improvement:

  • In file1.js, could you please add comments to explain the purpose of each function?
  • In file2.css, there is a typo on line 42. It should be background-color, not background-colorr.
  • In README.md, could you please use proper markdown syntax to format the code snippets?

Other than that, I have no further comments. Thank you for your hard work on this!

@pr-explainer-bot
Copy link

Greetings! Here's a summary of the previous results for the Pull Request review:

Changes 🛠️

  1. Version bump for all packages to 17.6.6
  2. Bumped semver dependency from 7.5.0 to 7.5.2 in package @commitlint/config-lerna-scopes
  3. Updated @commitlint/config-angular dependency from 17.6.5 to 17.6.6 in packages @commitlint/config-patternplate and @commitlint/lint
  4. Version bump for package @commitlint/travis-cli from 17.6.5 to 17.6.6
  5. Version bump for package @commitlint/root from 17.6.5 to 17.6.6

Suggestions 💡

  1. In file '@commitlint/travis-cli/package.json', line 1: 'name' field could be more descriptive
  2. In file '@commitlint/travis-cli/package.json', line 6: 'description' field could be more detailed
  3. In file '@commitlint/travis-cli/package.json', line 40: 'dependencies' field could be sorted alphabetically
  4. In file '@alias/commitlint-config-angular/package.json', line 5: version bumped to 17.6.6
  5. In file '@alias/commitlint-config-angular/package.json', line 31: dependency '@commitlint/config-angular' version bumped to 17.6.6
  6. In file '@alias/commitlint-config-lerna-scopes/package.json', line 5: version bumped to 17.6.6
  7. In file '@alias/commitlint-config-lerna-scopes/package.json', line 31: dependency '@commitlint/config-lerna-scopes' version bumped to 17.6.6
  8. In file '@alias/commitlint-config-patternplate/package.json', line 5: version bumped to 17.6.6
  9. In file '@alias/commitlint-config-patternplate/package.json', line 31: dependency '@commitlint/config-patternplate' version bumped to 17.6.6
  10. In file '@alias/commitlint/package.json', line 5: version bumped to 17.6.6
  11. In file '@alias/commitlint/package.json', line 36: dependency '@commitlint/cli' version bumped to 17.6.6
  12. In file '@commitlint/cli/package.json', line 2: version bumped to 17.6.6
  13. In file '@commitlint/cli/package.json', line 50: dependency '@commitlint/lint' version bumped to 17.6.6
  14. In file '@commitlint/config-angular/package.json', line 2: version bumped to 17.6.6
  15. In file '@commitlint/config-angular/package.json', line 32: dependency '@commitlint/lint' version bumped to 17.6.6
  16. In file @commitlint/config-lerna-scopes/package.json, line 8, change version from 17.6.3 to 17.6.6
  17. In file @commitlint/config-lerna-scopes/package.json, line 43, change semver dependency from 7.5.0 to 7.5.2
  18. In file @commitlint/lint/package.json, line 39, change @commitlint/is-ignored dependency from 17.6.5 to 17.6.6
  19. In file @commitlint/lint/package.json, line 40, change @commitlint/lint dependency from 17.6.5 to 17.6.6
  20. In file @commitlint/lint/package.json, line 41, change @commitlint/parse dependency from 17.6.5 to 17.6.6
  21. In file @commitlint/lint/package.json, line 42, change @commitlint/rules dependency from 17.6.5 to 17.6.6
  22. In file @commitlint/lint/package.json, line 43, change @commitlint/types dependency from 17.4.4 to 17.4.5

Bugs 🐛

No potential bugs found

Improvements 🚀

In file '@commitlint/travis-cli/package.json', the 'dependencies' field could be refactored for better readability by sorting the dependencies alphabetically.

Before:

"dependencies": {
  "@commitlint/cli": "^17.6.5",
  "execa": "^5.0.0"
}

After:

"dependencies": {
  "@commitlint/cli": "^17.6.6",
  "execa": "^5.0.0"
}

Rating ⭐

I cannot rate the code as I am not capable of analyzing the code for readability, performance, and security. Please consult a professional developer for a thorough code review.

That's it for the summary! Let me know if you need anything else.

@pull pull bot added the ⤵️ pull label Jun 25, 2023
* chore: update some deps incl. eslint fixes

* chore: update cosmicconfig

* revert: dep updates to test CI

* chore: update some deps

* chore: update some deps
@ammar-ahmed-butt ammar-ahmed-butt merged commit 6cdaffc into ammar-knowledge:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants