Feature/dynamic disk #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. For users utilizing S3 etc this might spare them a few confuse minutes looking for the output, and the hassle of donwloading them from S3
tomirons
requested changes
Feb 24, 2021
Co-authored-by: Tom Irons <[email protected]>
|
Great idea and addition, thank you 😄 |
tomirons
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured it would be nice to allow users to specify the disk for output. In my case I have S3 as project general disk - which made me confused looking for the output. In my suggestion the config defaults to the local disk, but the user is free to choose any other disk in config.