Added basic auth option #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Martincic this is a great idea, and congratulations on your first open-source contribution 🎉 I don't currently have time to properly test and feedback this, but once I do (and/or @tomirons does), one of us will get back to you. Thank you for your contribution 👍 |
|
All looks good to me here, so I'm happy to merge and tag a new release. Thanks again for your contribution to the package @Martincic, it is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed a basic auth option for my project so I added it here, it can be useful so why not share it I guess.
Edit: it's my first open-source contribution (🎉) so be gentle.