Skip to content

Fix custom rule usage #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 3, 2022
Merged

Fix custom rule usage #72

merged 15 commits into from
Jun 3, 2022

Conversation

andreaselia
Copy link
Owner

@andreaselia andreaselia commented May 31, 2022 •
edited
Loading

  • Reproduce the issue through the tests
  • Implement a fix

@andreaselia andreaselia mentioned this pull request May 31, 2022
Closed
@tomirons
Copy link
Collaborator

tomirons commented Jun 3, 2022

Custom rules should be skipped for now as they aren't supported.

@andreaselia andreaselia changed the title [WIP] Add custom rule support Add custom rule support Jun 3, 2022
@andreaselia andreaselia changed the title Add custom rule support Fix custom rule usage Jun 3, 2022
@andreaselia
Copy link
Owner Author

@robertmarney any ideas what the subclass code was initially for? 🤔

@tomirons tomirons merged commit 69d0221 into master Jun 3, 2022
@tomirons tomirons deleted the feature/custom-rule-support branch June 3, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomirons tomirons tomirons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaselia @tomirons