Fix collection merging bug #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Menkveld-24 good spot, and thanks for the PR. If you wouldn't mind extending the test surrounding this, that would be greatly appreciated 👍 |
|
Hi, sorry for the late response. Been busy these weeks and kinda forgot about it. I'll try to do so this week |
tomirons
requested changes
Apr 16, 2024
src/Processors/RouteProcessor.php
Outdated
| return $collection->put('url', [ | ||
| 'query' => $rules->map(fn ($value) => array_merge($value, ['disabled' => false])), | ||
| ]); | ||
| return $collection->mergeRecursive(collect([ |
There was a problem hiding this comment.
You don't need to create a new collection to use mergeRecursive(), a simple array should do.
|
Hehe, I've finally made some changes. Also; saw this message about the deprecation of some tests or sth. |
|
@Menkveld-24 there's a failing test, are you able to fix it? |
|
Ofc! Somehow they didnt produce this error locally |
|
@tomirons Should be good rn |
|
Thank you @Menkveld-24 and @tomirons ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ->put('url') overwrites the url part of the collection instead of adding to it upon GET requests.
Would you also like me to extend the test for this? As the test only looks for the 'query' part inside the 'url'?