Skip to content

refactor(prompts): alphabetize list options #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kingcody
Copy link
Member

@kingcody kingcody commented Aug 6, 2015

No description provided.

'JavaScript': 'js',
'CoffeeScript': 'coffee'
'CoffeeScript': 'coffee',
'JavaScript': 'js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a point to alphabetical sorting? I think it makes more sense to have JS first at least.

@kingcody
Copy link
Member Author

Well since we have generator defaults set, such as javascript over coffee, the alphabetizing is for readability and a consistent natural sorting order. Anyways, that's my opinion on it.

@Awk34
Copy link
Member

Awk34 commented Aug 10, 2015

I'm fine with the style changes and OAuth ordering, but I feel like JS should precede CoffeeScript. I think it makes more sense to have the simpler, non-transpiled language first, and then the more complicated options after. Same with CSS, but I think the default should follow right after the non-tranpiled language.

@kingcody
Copy link
Member Author

Speaking of, why do we default to sass instead of css?

@Awk34
Copy link
Member

Awk34 commented Aug 10, 2015

I believe it's the most popular option. I'd like to change the language options to the following too:

JavaScript
JavaScript + Babel
CoffeeScript

maybe having Babel default.

@Awk34 Awk34 added this to the 2.3.0 milestone Aug 11, 2015
@Awk34 Awk34 closed this Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants