A better require statement

[kevinawoo]

Closes issue #430 with a PR

[meeDamian]

You need to add package.json entry.

[kevinawoo]

@chester1000 Sorry, but I don't know what package.json entry is.

[meeDamian]

In app/templates/_package.json file, add relevant line in dependencies section.

If you're using this, then it would be:

"better-require": "~0.0.3"

[kevinawoo]

Oh wow, apparently I picked a bad name for my branch/PR.

What I actually did was added a new global function in app/templates/server/app.js

global.rootRequire = function (name) {
    return require(__dirname + '/' + name);
}

There wasn't any new package installs.

[meeDamian]

Oops, my bad (:

[kingcody]

@kevinawoo
I'm definitely not trying to be a sticker, but this project uses an automated task to generate the change log. It parses the commit messages looking for a particular format; outline here:
https://github.com/DaftMonk/generator-angular-fullstack/blob/master/contributing.md

If you could squash your commits into one that matches that format, it would be really nice.

If you have any trouble please feel free to MSG me or send me an email and I'll gladly see what I can do.

Thanks again for the PR!

[kingcody]

@kevinawoo, i'm wondering...

Should rootRequire use path.normalize() ?
ex:

var path = require('path');
...
global.rootRequire = function (name) {
  return require(path.normalize(config.root + '/' + name));
};

(btw, I threw in the use of config.root instead of __dirname, either way)

It would allow for:
rootRequire('config/environment')
OR
rootRequire('/config/environment')

Just a thought...

[kevinawoo]

You're absolutely right about path.normalize.

As for the config.root, my thinking behind using __dirname is to keep app.js and server/config/environment portable in the future, and to not confuse the reader, as they may think its a circular import.

[kingcody]

I see. My only thought was that if app.js wasn't in the 'root' folder (not really sure why it would be, but) config.root could be used to get the app's real root.

But I'm not sure if there would be much of a use case for that.

Long story, short:
either __dirname or config .root, probably doesn't matter that much :)

[kevinawoo]

@kingcody you did get me thinking about config.root though. Root always confused me a bit. "Did you mean root project, server root, ...client root??"

Since we're here, what do you think about changing it to:

config = {
   ...
  path: {
    project: ... '.',
    client: ... '/client',
    server: ... '/server'
  },
...
}

[kingcody]

@kevinawoo you've made a good point. I'd definitely be interested to see what others have to say in regards to this.

Although I will point out that it is a server config. Valid point none the less :)