Authorization for UI-Router #840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2015 15:50
Added authorize param to check if user is admin
added authorize for admin state
|
Does this have any upside when compared to what's already being done in |
|
Not sure what you mean by whats already being don in app.js. This allows you to add an authorize: parameter on the ui-router configuration which requires the user to have a specific role. |
added 2 commits
May 4, 2015 10:29
Changed isActive to look for indexOf if route is not /. Allows the navbar to highlight correctly for nesed routes. /admin/account etc.
|
@trainerbill sorry I misunderstood what the PR was. Would you please also update the coffescript files and adhere to the Contributing Guidelines? |
|
Closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option to add authoirze: 'admin' to the state to only allow admin users access to the state.