Revert pr11428 #11587
Merged
Revert pr11428 #11587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0bef5aa.
This reverts commit 47f937e. This commit had a few issues detected by the NativeScript project. It is likely that they would have affected more users (and libraries) and so it is safer to revert now and investigate later. Will likely be fixed in 6.2 by refactoring this whole plugin properly.
clydin
approved these changes
Jul 18, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 47f937e commit had a few issues detected by the NativeScript project. It is
likely that they would have affected more users (and libraries) and so
it is safer to revert now and investigate later. Will likely be fixed in
6.2 by refactoring this whole plugin properly.
The other revert is for a commit that was attempting to fix the first one.