Skip to content

build: update bazel dependencies and configuration #15291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 9, 2019

This leverages the configuration from FW as much as possible.
Bazel updated to 0.28.1
Rules for nodejs/typescript/karma/jasmine updated to 0.35.0

Ran into issues using the managed directories with yarn workspaces so that is disabled in the yarn install rule for now.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 9, 2019
@clydin clydin force-pushed the update-bazel branch 2 times, most recently from 71cf56d to 23db5b3 Compare August 9, 2019 18:33
@clydin clydin requested a review from josephperrott August 9, 2019 18:41
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This leverages the configuration from FW where possible.
Bazel updated to 28.1
Rules for nodejs/typescript/karma/jasmine updated to 0.35.0
@mgechev mgechev merged commit 920ee85 into angular:master Aug 12, 2019
@clydin clydin deleted the update-bazel branch August 12, 2019 18:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants