Skip to content

test: add E2E test for only ES2015 ngcc with differential loading #15322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

test: add E2E test for only ES2015 ngcc with differential loading #15322

merged 1 commit into from
Aug 13, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 13, 2019

No description provided.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 13, 2019
@clydin clydin requested a review from alan-agius4 August 13, 2019 17:11
@clydin clydin force-pushed the e2e-ensure-ngcc-es2015 branch from bc87a99 to 60de758 Compare August 13, 2019 17:38
alan-agius4
alan-agius4 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should go under the folder ivy instead of misc?

Otherwise LGTM

@clydin clydin force-pushed the e2e-ensure-ngcc-es2015 branch from 60de758 to 5d89fcf Compare August 13, 2019 17:57
@clydin
Copy link
Member Author

clydin commented Aug 13, 2019

moved it under the ivy directory

@mgechev mgechev merged commit 6dd5b18 into angular:master Aug 13, 2019
@clydin clydin deleted the e2e-ensure-ngcc-es2015 branch August 13, 2019 22:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clydin @alan-agius4 @mgechev @googlebot