Skip to content

build: 1.17.3 and ensure all https in yarn lock #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Aug 27, 2019
@josephperrott josephperrott force-pushed the yarn-fix branch 3 times, most recently from 47bd262 to 10d626d Compare August 27, 2019 15:38
@alan-agius4 alan-agius4 removed the request for review from filipesilva August 27, 2019 15:39
@alan-agius4
Copy link
Collaborator

@josephperrott It is very unlikely that this PR will apply cleanly on the patch branch, since you amended the lock file.

@alan-agius4
Copy link
Collaborator

Umm.. fail("Unknown Yarn version {}".format...))

@josephperrott josephperrott added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 27, 2019
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be bumped to 10.16 as well:
https://github.com/angular/angular-cli/blob/master/.circleci/config.yml#L203

The Node 10 job only runs on master.

@mgechev mgechev merged commit 84680d0 into angular:master Aug 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
@josephperrott josephperrott deleted the yarn-fix branch October 13, 2021 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants