Skip to content

fix(@angular/cli): handle promise rejection on analytics install prompt #15455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 27, 2019

A rejection in this case should be ignored to prevent potential installation failure.

A rejection in this case should be ignored to prevent potential installation failure.
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 27, 2019
@clydin clydin requested a review from alan-agius4 August 27, 2019 15:34
@mgechev mgechev merged commit 5606a4c into angular:master Aug 27, 2019
@clydin clydin deleted the fix-analytics-prompt-2 branch August 27, 2019 17:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants