Skip to content

docs: corrected spelling of Globally under Installation section #15905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

noopur-tiwari
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@noopur-tiwari
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@alan-agius4
Copy link
Collaborator

@noopur-tiwari thanks for this, can you kindly fix the commit msg to docs: corrected spelling of Globally under Installation section

Thanks

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 22, 2019
@noopur-tiwari noopur-tiwari changed the title Corrected spelling of Globally under Installation section. docs: corrected spelling of Globally under Installation section Oct 22, 2019
@alan-agius4
Copy link
Collaborator

Caretaker: can you please reword the commit?

@noopur-tiwari
Copy link
Contributor Author

Caretaker: can you please reword the commit?

Sorry I couldn't get you. I have modified the Commit message based on your input
from
**

"Corrected spelling of Globally under Installation section."

**
to
**

"docs: corrected spelling of Globally under Installation section"

**

Is anything else needed from my side?

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Caretaker: see above

@alan-agius4
Copy link
Collaborator

@noopur-tiwari, actually you didn’t rename the commit msg, but rather just the PR title.

Don’t worry, our caretaker will rename it when merging.

Thanks for your contribution.

@vikerman vikerman merged commit e7bc270 into angular:master Oct 23, 2019
@noopur-tiwari noopur-tiwari deleted the noopur-tiwari branch October 24, 2019 04:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants