docs(@angular/cli): Adds developer documentation and Intellij setup. #16152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
requested changes
Nov 12, 2019
There was a problem hiding this comment.
Can you split this into several commits? Probably three:
- The README updates
- git ignore improvements
- IntelliJ setup
The last may need some discussion with the team as I believe there were previous concerns with adding IDE specific configuration into the repositories.
…ellij configurations. This also changes the local build script to allow negated .gitignore expressions to support these changes.
This should enable using Intellij IDEA/WebStorm to create the project, run it, and start a debugger. I did my best to make sure my personal configuration didn't leak in, someone else will have to confirm that this works reasonably for them too.
dgp1130
force-pushed
the
dev-docs
branch
2 times, most recently
from
9f982fd to
46de409
Compare
|
I split up the commits and moved my README edits to |
I wrote down my understanding of the best ways to build/run/test/debug this repository. A couple other random things included here: * Removed an extraneous `debugger;` statement which I kept hitting. * Removed the `watch` scripts which are no longer used and don't need to be supported. * Removed `yarn test-cli-e2e`, as it alters the $PATH and can use the wrong `ng` instance.
clydin
approved these changes
Nov 14, 2019
|
Do you think we need to discuss the IntelliJ configs with the team or should I just merge this? |
clydin
added
the
needs: discussion
|
To be safe, added the discussion label for tomorrow's triage meeting. |
filipesilva
removed
the
needs: discussion
|
Concerns in the meeting were able not forcing personal configuration settings (such as themeing) directly in the repo. IntelliJ doesn't really put personal settings like that in these files. The settings will be picked up by default, but users should be able to change and modify them as they wish independently from the setting stored in source control. |
ahasall
added a commit
to ahasall/angular-cli
that referenced
this pull request
Nov 18, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system.For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Therefore, I think that the modules.xml and iml should be left out from version control. refs angular#16152
ahasall
added a commit
to ahasall/angular-cli
that referenced
this pull request
Nov 18, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system. For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Therefore, I think that the modules.xml and iml should be left out from version control. refs angular#16152
ahasall
added a commit
to ahasall/angular-cli
that referenced
this pull request
Nov 18, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system. For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Therefore, I think that the modules.xml and iml should be left out from version control. refs angular#16152
ahasall
added a commit
to ahasall/angular-cli
that referenced
this pull request
Nov 19, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system. For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Therefore, I think that the modules.xml and iml should be left out from version control. refs angular#16152
ahasall
added a commit
to ahasall/angular-cli
that referenced
this pull request
Nov 19, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system. For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Let's use `WEB_MODULE` as it's recognized by both IDEs. refs angular#16152
dgp1130
pushed a commit
that referenced
this pull request
Nov 19, 2019
Intellij and Webstorm unfortunately don't the use the exact same configuration system. For example, Intellij treats every project as `JAVA_MODULE` but Webstorm doesn't recognize the `JAVA_MODULE`. Let's use `WEB_MODULE` as it's recognized by both IDEs. refs #16152
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote down my understanding of the best ways to build/run/test/debug this repository. I also included some configs for Intellij to work a little bit better "out of the box".
I tried to get VSCode to work as well, however the debugger there was having trouble loading source maps, so I'll need to come back to that later.
Changes include:
nodemonas a dev dependency, which is needed for watch executions but wasn't listed.debugger;statement which I kept hitting.