Skip to content

fix(@angular/cli): remove alias for doc command #16364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(@angular/cli): remove alias for doc command #16364

wants to merge 1 commit into from

Conversation

kasaharu
Copy link
Contributor

@kasaharu kasaharu commented Dec 5, 2019

Suggestion

  • I want to remove the alias for doc

Why

  • Because alias 'd' is a duplicate.
  • The image below shows the result of the $ ng help command.

ng-help

  • I have confirmed that if there are multiple same alias, the first command found is executed.

version

  • Angular CLI : 8.3.20

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release needs: discussion On the agenda for team meeting to determine next steps labels Dec 5, 2019
@vikerman
Copy link
Contributor

vikerman commented Dec 5, 2019

Can you please keep the alias for doc and remove the one for deploy?

It better if ng d went to doc when someone meant deploy than if it went to deploy when they meant doc.

@vikerman vikerman removed the needs: discussion On the agenda for team meeting to determine next steps label Dec 5, 2019
clydin
clydin requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment for suggested changes.

@kasaharu
Copy link
Contributor Author

kasaharu commented Dec 5, 2019

Thank you for your review! I will fix by another PR😄

@kasaharu kasaharu mentioned this pull request Dec 5, 2019
Merged
@kasaharu
Copy link
Contributor Author

kasaharu commented Dec 5, 2019

I was fixed at #16368🙂
So, I close this PR.

@kasaharu kasaharu closed this Dec 5, 2019
@alan-agius4
Copy link
Collaborator

Superseded by #16368

@kasaharu kasaharu deleted the remove-alias-for-doc branch December 5, 2019 22:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin requested changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kasaharu @vikerman @alan-agius4 @clydin @googlebot