Skip to content

fix(@schematics/angular): remove async test helper function from component schematic #18243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 13, 2020

jasmine has supported promises and async/await natively since 2.7.
The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await provides equivalent functionality in this context without the need for an additional Zone.js layer.
While the call to compileComponents is typically unneeded when using ng test, the generated test files may be also be used outside the command.

@clydin clydin requested a review from alan-agius4 July 13, 2020 22:03
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 14, 2020
@clydin clydin merged commit 872bd48 into angular:master Jul 15, 2020
@clydin clydin deleted the schematics-remove-async-helper branch July 15, 2020 16:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants