Skip to content

build: re-enable Material tests #25930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

build: re-enable Material tests #25930

merged 1 commit into from
Oct 9, 2023

Conversation

crisbeto
Copy link
Member

Re-enables Material tests that had to be disabled during the TS 5.2 update.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 30, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 30, 2023
@crisbeto
Copy link
Member Author

crisbeto commented Oct 1, 2023 •
edited
Loading

I suspect this shows a breakage introduced in angular/components#27792. It didn't show up since the breakage came up while the test was disabled.

@crisbeto crisbeto force-pushed the material-tests-cleanup branch 2 times, most recently from 747e1c3 to a9c80e0 Compare October 5, 2023 01:36
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2023
@alan-agius4
Copy link
Collaborator

@crisbeto looks like https://github.com/angular/angular-cli/blob/a9c80e00d7d93459f5efdb7b2de2127ca9468d7a/tests/legacy-cli/e2e/tests/build/material.ts needs to be updated since ng-new apps are not standalone by default.

@crisbeto
build: re-enable Material tests
7a345e6 
Re-enables Material tests that had to be disabled during the TS 5.2 update.
@crisbeto crisbeto force-pushed the material-tests-cleanup branch from a9c80e0 to 7a345e6 Compare October 9, 2023 10:55
@crisbeto
Copy link
Member Author

crisbeto commented Oct 9, 2023

@alan-agius4 it's fixed now.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 9, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2023
@alan-agius4 alan-agius4 merged commit 54794c9 into angular:main Oct 9, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @alan-agius4