Skip to content

docs(@angular/cli): document resource copy #6323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2017
Merged

docs(@angular/cli): document resource copy #6323

merged 2 commits into from
May 15, 2017

Conversation

filipesilva
Copy link
Contributor

No description provided.

sumitarora
sumitarora previously approved these changes May 15, 2017
View reviewed changes
@sumitarora sumitarora requested a review from hansl May 15, 2017 16:30
@sumitarora sumitarora self-assigned this May 15, 2017
@filipesilva filipesilva changed the title doc(@angular/cli): document resource copy docs(@angular/cli): document resource copy May 15, 2017
hansl
hansl previously approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@hansl
Copy link
Contributor

hansl commented May 15, 2017

CLA bot it's okay, I just merged it using the github ui.

@hansl hansl merged commit 272766f into angular:master May 15, 2017
sumitarora pushed a commit that referenced this pull request May 15, 2017
@filipesilva @sumitarora
docs(@angular/cli): document resource copy (#6323)
38cb0e6
@filipesilva filipesilva deleted the img-inline-doc branch May 16, 2017 09:57
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@filipesilva @dond2clouds
docs(@angular/cli): document resource copy (angular#6323)
e5c1a88
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumitarora sumitarora sumitarora left review comments

@hansl hansl hansl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filipesilva @googlebot @hansl @sumitarora