Skip to content

fix(bazel): don't equate moduleName with fileName #20895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): don't equate moduleName with fileName #20895

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

Fixes broken material build.
/cc @jelbourn

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@alexeagle alexeagle requested a review from chuckjaz December 8, 2017 19:49
@mary-poppins
Copy link

You can preview 5a0076f at https://pr20895-5a0076f.ngbuilds.io/.

@jasonaden jasonaden added the area: bazel Issues related to the published `@angular/bazel` build rules label Dec 8, 2017
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Dec 8, 2017
@jasonaden jasonaden added the target: major This PR is targeted for the next major release label Dec 11, 2017
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Dec 11, 2017
jasonaden pushed a commit that referenced this pull request Dec 11, 2017
@alexeagle @jasonaden
fix(bazel): don't equate moduleName with fileName (#20895)
0c9f7b0 
Fixes broken material build.
/cc @jelbourn
PR Close #20895
@jasonaden jasonaden closed this in f05937d Dec 11, 2017
jelbourn added a commit to jelbourn/components that referenced this pull request Dec 14, 2017
@jelbourn
chore: update to Angular 5.1.1 to fix bazel build
dc052b7 
A bug in @angular/bazel caused some cdk targets to fail. The issue was
fixed in angular/angular#20895
@jelbourn jelbourn mentioned this pull request Dec 14, 2017
Merged
jelbourn added a commit to jelbourn/components that referenced this pull request Dec 18, 2017
@jelbourn
chore: update to Angular 5.1.1 to fix bazel build
2c72aca 
A bug in @angular/bazel caused some cdk targets to fail. The issue was
fixed in angular/angular#20895
@alexeagle alexeagle deleted the alexeagle-patch-2 branch February 19, 2018 15:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckjaz chuckjaz chuckjaz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexeagle @mary-poppins @chuckjaz @jasonaden @googlebot