Redo dev infra benchmarking #36800

wagnermaciel · 2020-04-24T20:20:04Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Context

These changes were already submitted once in PR #36721. They were reverted by PR #36798 when @AndrewKushnir noticed that the updated files in the modules folder refer to the dev-infra package that we do not sync in g3, which would likely have caused build failures. I am not sure why NG Bot indicated (in “g3 status”) that the first PR wouldn't affect g3, when in fact it would have.

The difference between this PR and the previous one is that it has been g3synced using CL #309492386's copy.bara.sky configuration. This change syncs dev-infra/benchmark/driver-utilities/** into g3.

The commit messages (while they are confusing) reflect the correct history of these changes. I am OK with changing them if we would prefer to have clarity over historical accuracy in this case.

tools/gulp-tasks/format.js

IgorMinar

Hey Wagner!

What's going on with this PR? Can you please provide a bit more context? Thanks

Side-note: the current commit messages just state that these are reverts of reverts which is a bit confusing. But let's sort out what you are trying to do here before we worry about the commit messages.

wagnermaciel · 2020-05-07T16:52:30Z

Hi Igor,

For context, these changes were already submitted once in PR #36721. They were reverted by PR #36798 when @AndrewKushnir noticed that the updated files in the modules folder refer to the dev-infra package that we do not sync in g3, which would likely have caused build failures. I am not sure why NG Bot indicated (in “g3 status”) that the first PR wouldn't affect g3, when in fact it would have.

The difference between this PR and the previous one is that it has been g3synced using CL #309492386's copy.bara.sky configuration. This change syncs dev-infra/benchmark/driver-utilities/** into g3.

The commit messages (while they are confusing) reflect the correct history of these changes. I am OK with changing them if we would prefer to have clarity over historical accuracy in this case.

I have added this to the PR description and if you would like I can also add this to the body of a commit message.

dev-infra/BUILD.bazel

dev-infra/benchmark/driver-utilities/BUILD.bazel

dev-infra/tmpl-package.json

devversion

LGTM. A few minor comments from my side.

dev-infra/BUILD.bazel

dev-infra/benchmark/component_benchmark/component_benchmark.bzl

dev-infra/benchmark/driver-utilities/BUILD.bazel

modules/benchmarks/tsconfig.json

tools/defaults.bzl

kyliau

LGTM for language service

mhevery

LGTM for zone.js

wagnermaciel · 2020-06-01T23:15:50Z

This has a passing presubmit
https://tap.corp.google.com/ui#id=OCL:312733720:BASE:314181500:1591040024284:2b3c7ff4

The status isn't updating due to a rate limit error. This should be good to merge.

…ark' via dev_infra (angular#36434)" (angular#36798)" This reverts commit ad8c4cd.

…age (angular#36434)" (angular#36798)" This reverts commit f5ff206.

… show PoC (angular#36434)" (angular#36798)" This reverts commit 90a2796.

wagnermaciel · 2020-06-02T18:50:43Z

Currently rebasing to try and get around GitHub's status limit. Code should still be safe to merge, I am just trying to update the status here.

Update: Rebasing did not allow me to update the status. Still getting rate limited by GitHub. To reiterate, this PR has a passing presubmit
https://tap.corp.google.com/ui#id=OCL:312733720:BASE:314181500:1591040024284:2b3c7ff4

josephperrott

LGTM

Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers.

…age (#36434)" (#36798)" (#36800) This reverts commit f5ff206. PR Close #36800

… show PoC (#36434)" (#36798)" (#36800) This reverts commit 90a2796. PR Close #36800

Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers. PR Close #36800

…ark' via dev_infra (#36434)" (#36798)" (#36800) This reverts commit ad8c4cd. PR Close #36800

…age (#36434)" (#36798)" (#36800) This reverts commit f5ff206. PR Close #36800

… show PoC (#36434)" (#36798)" (#36800) This reverts commit 90a2796. PR Close #36800

Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers. PR Close #36800

…ark' via dev_infra (angular#36434)" (angular#36798)" (angular#36800) This reverts commit ad8c4cd. PR Close angular#36800

…age (angular#36434)" (angular#36798)" (angular#36800) This reverts commit f5ff206. PR Close angular#36800

… show PoC (angular#36434)" (angular#36798)" (angular#36800) This reverts commit 90a2796. PR Close angular#36800

Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers. PR Close angular#36800

angular-automatic-lock-bot · 2020-07-04T16:13:10Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…ark' via dev_infra (angular#36434)" (angular#36798)" (angular#36800) This reverts commit ad8c4cd. PR Close angular#36800

…age (angular#36434)" (angular#36798)" (angular#36800) This reverts commit f5ff206. PR Close angular#36800

… show PoC (angular#36434)" (angular#36798)" (angular#36800) This reverts commit 90a2796. PR Close angular#36800

Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers. PR Close angular#36800

googlebot added the cla: yes label Apr 24, 2020

wagnermaciel requested a review from jelbourn April 27, 2020 22:00

jelbourn reviewed Apr 28, 2020

View reviewed changes

tools/gulp-tasks/format.js Outdated Show resolved Hide resolved

wagnermaciel marked this pull request as ready for review April 28, 2020 23:07

pullapprove bot requested review from gkalpak, IgorMinar, kara, kyliau and mhevery April 28, 2020 23:07

AndrewKushnir added the area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) label Apr 29, 2020

ngbot bot added this to the needsTriage milestone Apr 29, 2020

IgorMinar suggested changes May 7, 2020

View reviewed changes

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch 2 times, most recently from 5d7d209 to 3ea9584 Compare May 7, 2020 17:08

wagnermaciel requested review from devversion and josephperrott May 7, 2020 17:09

josephperrott reviewed May 8, 2020

View reviewed changes

dev-infra/BUILD.bazel Outdated Show resolved Hide resolved

dev-infra/benchmark/driver-utilities/BUILD.bazel Show resolved Hide resolved

dev-infra/tmpl-package.json Outdated Show resolved Hide resolved

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch from 857d98f to 96ddbc9 Compare May 8, 2020 22:31

wagnermaciel mentioned this pull request May 11, 2020

feat(benchmarks): setup for benchmarking components angular/components#19320

Merged

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch 2 times, most recently from 45fe6e4 to f1e5878 Compare May 11, 2020 18:47

devversion approved these changes May 12, 2020

View reviewed changes

wagnermaciel requested review from IgorMinar and removed request for kara May 12, 2020 17:15

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch 3 times, most recently from ee83640 to f78059a Compare May 15, 2020 18:23

kyliau approved these changes May 15, 2020

View reviewed changes

mhevery approved these changes May 15, 2020

View reviewed changes

ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jun 1, 2020

wagnermaciel added 3 commits June 2, 2020 11:49

revert: "revert: "feat(dev-infra): exposed new rule 'component_benchm…

8bab4bb

…ark' via dev_infra (angular#36434)" (angular#36798)" This reverts commit ad8c4cd.

revert: "revert: "build(dev-infra): update package.json and :npm_pack…

9d3a641

…age (angular#36434)" (angular#36798)" This reverts commit f5ff206.

revert: "revert: "build(core): use dev-infra's component_benchmark to…

f70ced7

… show PoC (angular#36434)" (angular#36798)" This reverts commit 90a2796.

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch from 8d9d51a to b19436a Compare June 2, 2020 18:49

josephperrott approved these changes Jun 2, 2020

View reviewed changes

wagnermaciel added the target: patch This PR is targeted for the next patch release label Jun 2, 2020

wagnermaciel force-pushed the redo-dev-infra-benchmarking branch from b19436a to 987fe29 Compare June 2, 2020 19:26

atscott removed the request for review from gkalpak June 3, 2020 20:11

atscott closed this in caa4ab3 Jun 3, 2020

atscott pushed a commit that referenced this pull request Jun 3, 2020

revert: "revert: "build(dev-infra): update package.json and :npm_pack…

64d6f35

…age (#36434)" (#36798)" (#36800) This reverts commit f5ff206. PR Close #36800

atscott pushed a commit that referenced this pull request Jun 3, 2020

revert: "revert: "build(core): use dev-infra's component_benchmark to…

a08d18a

… show PoC (#36434)" (#36798)" (#36800) This reverts commit 90a2796. PR Close #36800

atscott pushed a commit that referenced this pull request Jun 3, 2020

revert: "revert: "feat(dev-infra): exposed new rule 'component_benchm…

7be8bb1

…ark' via dev_infra (#36434)" (#36798)" (#36800) This reverts commit ad8c4cd. PR Close #36800

atscott pushed a commit that referenced this pull request Jun 3, 2020

revert: "revert: "build(dev-infra): update package.json and :npm_pack…

cba1da3

…age (#36434)" (#36798)" (#36800) This reverts commit f5ff206. PR Close #36800

atscott pushed a commit that referenced this pull request Jun 3, 2020

revert: "revert: "build(core): use dev-infra's component_benchmark to…

6755d00

… show PoC (#36434)" (#36798)" (#36800) This reverts commit 90a2796. PR Close #36800

ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020

revert: "revert: "build(dev-infra): update package.json and :npm_pack…

336005a

…age (angular#36434)" (angular#36798)" (angular#36800) This reverts commit f5ff206. PR Close angular#36800

ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020

revert: "revert: "build(core): use dev-infra's component_benchmark to…

abe5d4a

… show PoC (angular#36434)" (angular#36798)" (angular#36800) This reverts commit 90a2796. PR Close angular#36800

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2020

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

revert: "revert: "build(dev-infra): update package.json and :npm_pack…

170034e

…age (angular#36434)" (angular#36798)" (angular#36800) This reverts commit f5ff206. PR Close angular#36800

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

revert: "revert: "build(core): use dev-infra's component_benchmark to…

fd6bfc5

… show PoC (angular#36434)" (angular#36798)" (angular#36800) This reverts commit 90a2796. PR Close angular#36800

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Redo dev infra benchmarking #36800

Redo dev infra benchmarking #36800

Uh oh!

wagnermaciel commented Apr 24, 2020 •

edited

Loading

Uh oh!

Uh oh!

IgorMinar left a comment

Uh oh!

wagnermaciel commented May 7, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyliau left a comment

Uh oh!

mhevery left a comment

Uh oh!

wagnermaciel commented Jun 1, 2020

Uh oh!

wagnermaciel commented Jun 2, 2020 •

edited

Loading

Uh oh!

josephperrott left a comment

Uh oh!

angular-automatic-lock-bot bot commented Jul 4, 2020

Uh oh!

Uh oh!

Redo dev infra benchmarking #36800

Redo dev infra benchmarking #36800

Uh oh!

Conversation

wagnermaciel commented Apr 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Context

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

wagnermaciel commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyliau left a comment

Choose a reason for hiding this comment

Uh oh!

mhevery left a comment

Choose a reason for hiding this comment

Uh oh!

wagnermaciel commented Jun 1, 2020

Uh oh!

wagnermaciel commented Jun 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Jul 4, 2020

Uh oh!

Uh oh!

wagnermaciel commented Apr 24, 2020 •

edited

Loading

wagnermaciel commented May 7, 2020 •

edited

Loading

wagnermaciel commented Jun 2, 2020 •

edited

Loading