Skip to content

refactor(docs-infra): refactors extractDecoratedClasses #37135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(docs-infra): refactors extractDecoratedClasses #37135

wants to merge 1 commit into from

Conversation

sonukapoor
Copy link
Contributor

This commit removes the dependency on the lodash module and refactors
the extractDecoratedClasses method.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@sonukapoor
refactor(docs-infra): refactors extractDecoratedClasses
d0a1db6 
This commit removes the dependency on the `lodash` module and refactors
the `extractDecoratedClasses` method.
@pullapprove pullapprove bot requested a review from IgorMinar May 15, 2020 15:21
@ngbot ngbot bot added this to the needsTriage milestone May 15, 2020
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release refactoring Issue that involves refactoring or code-cleanup labels May 17, 2020
gkalpak
gkalpak approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@gkalpak gkalpak removed the request for review from IgorMinar May 17, 2020 22:12
@kara kara closed this in 8999507 May 18, 2020
kara pushed a commit that referenced this pull request May 18, 2020
@sonukapoor @kara
refactor(docs-infra): refactors extractDecoratedClasses (#37135)
7543e59 
This commit removes the dependency on the `lodash` module and refactors
the `extractDecoratedClasses` method.

PR Close #37135
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@sonukapoor @profanis
refactor(docs-infra): refactors extractDecoratedClasses (angular#37135
6ec1015 
)

This commit removes the dependency on the `lodash` module and refactors
the `extractDecoratedClasses` method.

PR Close angular#37135
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
4 participants
@sonukapoor @gkalpak @kara @googlebot