Skip to content

docs: supply correct manifest.webmanifest filename #37146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jorroll
Copy link
Contributor

@jorroll jorroll commented May 15, 2020

Previously, the docs incorrectly identified the generated manifest file as "manifest.json" when it is actually "manifest.webmanifest".

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Currently the docs incorrectly reference the generated service worker manifest file as "manifest.json" when it is actually named "manifest.webmanifest".

What is the new behavior?

Now, the docs correctly reference the generated service worker manifest file as "manifest.webmanifest"

Does this PR introduce a breaking change?

  • No

Other information

Previously, the docs incorrectly identified the generated manifest file as "manifest.json" when it is actually "manifest.webmanifest".
@pullapprove pullapprove bot requested a review from gkalpak May 15, 2020 22:46
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thx 👍

For future PRs, try to use the correct commit message scope (see here for details) for docs commits. E.g. this one should have been docs(service-worker): ....

@gkalpak gkalpak added comp: docs area: service-worker Issues related to the @angular/service-worker package action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix labels May 17, 2020
@ngbot ngbot bot modified the milestone: needsTriage May 17, 2020
@jorroll
Copy link
Contributor Author

jorroll commented May 17, 2020

I had mistakenly just read the text between the "Commit Message Format" and "Revert" headers and thought that, since the scope was described as optional, I could just leave it out.

@kara kara closed this in c2fa656 May 18, 2020
kara pushed a commit that referenced this pull request May 18, 2020
Previously, the docs incorrectly identified the generated manifest file as "manifest.json" when it is actually "manifest.webmanifest".
PR Close #37146
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Previously, the docs incorrectly identified the generated manifest file as "manifest.json" when it is actually "manifest.webmanifest".
PR Close angular#37146
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants