feat(dev-infra): save invalid commit message attempts to be restored on next commit attempt #38304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
action: review
|
Setting @alxhub as a reviewer as this feature was at his request. Can you confirm this is what you were looking for? |
josephperrott
force-pushed
the
commit-message-resume
branch
2 times, most recently
from
7e4983e to
f024f67
Compare
devversion
approved these changes
Aug 3, 2020
josephperrott
force-pushed
the
commit-message-resume
branch
from
6fbbbf1 to
36c1bd2
Compare
…on next commit attempt When a commit message fails validation, rather than throwing out the commit message entirely the commit message is saved into a draft file and restored on the next commit attempt.
…stored on next commit attempt
…stored on next commit attempt
josephperrott
force-pushed
the
commit-message-resume
branch
from
36c1bd2 to
c09377a
Compare
gkalpak
approved these changes
Aug 13, 2020
josephperrott
removed
the
action: review
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…on next commit attempt (angular#38304) When a commit message fails validation, rather than throwing out the commit message entirely the commit message is saved into a draft file and restored on the next commit attempt. PR Close angular#38304
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a commit message fails validation, rather than throwing out the commit message entirely
the commit message is saved into a draft file and restored on the next commit attempt.