fix(localize): render ICU placeholders in extracted translation files #38484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addiational tests check that ICUs containing interpolations are serialized correctly.
Previously placeholders were only rendered for dynamic interpolation expressons in `$localize` tagged strings. But there are also potentially dynamic values in ICU expressions too, so we need to render these as placeholders when extracting i18n messages into translation files.
petebacondarwin
added
type: bug/fix
action: review
AndrewKushnir
approved these changes
Aug 16, 2020
packages/localize/src/tools/src/extract/translation_files/icu_parsing.ts
Outdated
Show resolved
Hide resolved
petebacondarwin
added
action: merge
atscott
added
target: major
atscott
pushed a commit
that referenced
this pull request
Aug 17, 2020
…#38484) Previously placeholders were only rendered for dynamic interpolation expressons in `$localize` tagged strings. But there are also potentially dynamic values in ICU expressions too, so we need to render these as placeholders when extracting i18n messages into translation files. PR Close #38484
subratpalhar92
pushed a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 29, 2020
The addiational tests check that ICUs containing interpolations are serialized correctly. PR Close angular#38484
subratpalhar92
pushed a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 29, 2020
…angular#38484) Previously placeholders were only rendered for dynamic interpolation expressons in `$localize` tagged strings. But there are also potentially dynamic values in ICU expressions too, so we need to render these as placeholders when extracting i18n messages into translation files. PR Close angular#38484
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
…on files (angular#38484)" This reverts commit 5bb5494.
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
…lar#38484)" This reverts commit b24bc24.
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The addiational tests check that ICUs containing interpolations are serialized correctly. PR Close angular#38484
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…angular#38484) Previously placeholders were only rendered for dynamic interpolation expressons in `$localize` tagged strings. But there are also potentially dynamic values in ICU expressions too, so we need to render these as placeholders when extracting i18n messages into translation files. PR Close angular#38484
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously placeholders were only rendered for dynamic interpolation
expressons in
$localizetagged strings. But there are also potentiallydynamic values in ICU expressions too, so we need to render these as
placeholders when extracting i18n messages into translation files.
Fixes #38437