docs: remove empty onInit() & constructors #48576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
docs/tour-of-heroes-oninit
branch
2 times, most recently
from
0094b53 to
281ef20
Compare
hexiaokang
approved these changes
Dec 23, 2022
JeanMeche
changed the title
This was referenced Dec 24, 2022
|
@dylhunn My bad, It's pointing at the wrong repo : angular/angular-cli#24008, |
14 tasks
JeanMeche
force-pushed
the
docs/tour-of-heroes-oninit
branch
from
d806058 to
26e1cb1
Compare
AndrewKushnir
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
LGTM 👍
(this PR will require a rebase once PR #48546 lands, adding the "cleanup" label for now)
AndrewKushnir
added
action: cleanup
|
@JeanMeche PR #48546 is now merged, could you please rebase this PR and resolve merge conflicts? |
Following angular#24008, the schematics don't produce ngOnInit and the constructor. Let's reflect that in the Tour of Heroes tutorial. Fixes angular#48575
JeanMeche
force-pushed
the
docs/tour-of-heroes-oninit
branch
from
26e1cb1 to
94b490a
Compare
AndrewKushnir
approved these changes
Jan 5, 2023
AndrewKushnir
added
action: merge
|
Caretaker note: low risk PR, current set of approvals should be sufficient. |
jessicajaniuk
removed
the
merge: caretaker note
|
This PR was merged into the repository by commit 43ced45. |
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
Following angular#24008, the schematics don't produce ngOnInit and the constructor. Let's reflect that in the Tour of Heroes tutorial. Fixes angular#48575 PR Close angular#48576
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following angular/angular-cli#24008, the schematics don't produce ngOnInit and the constructor anymore. Let's reflect that in the Tour of Heroes tutorial.
Edit: I also removed it from other parts of the documentation.
Fixes #48575
PR Type
What kind of change does this PR introduce?