Skip to content

Commit 1acda9a

Browse files
rafaelss95tinayuangao
authored andcommitted
refactor(tree): ensure input is applied to the getter and not the setter (#10764)
1 parent 57efa13 commit 1acda9a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/cdk/tree/padding.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,21 @@ export class CdkTreeNodePadding<T> implements OnDestroy {
2626

2727
/** The level of depth of the tree node. The padding will be `level * indent` pixels. */
2828
@Input('cdkTreeNodePadding')
29+
get level(): number { return this._level; }
2930
set level(value: number) {
3031
this._level = coerceNumberProperty(value);
3132
this._setPadding();
3233
}
33-
get level(): number { return this._level; }
3434
_level: number;
3535

3636
/** The indent for each level. Default number 40px from material design menu sub-menu spec. */
3737
// TODO(tinayuangao): Make indent working with a string with unit, e.g. 10em
3838
@Input('cdkTreeNodePaddingIndent')
39+
get indent(): number { return this._indent; }
3940
set indent(value: number) {
4041
this._indent = coerceNumberProperty(value);
4142
this._setPadding();
4243
}
43-
get indent(): number { return this._indent; }
4444
_indent: number = 40;
4545

4646
constructor(private _treeNode: CdkTreeNode<T>,

src/cdk/tree/tree.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -648,8 +648,8 @@ class FakeDataSource extends DataSource<TestData> {
648648
isConnected = false;
649649

650650
_dataChange = new BehaviorSubject<TestData[]>([]);
651-
set data(data: TestData[]) { this._dataChange.next(data); }
652651
get data() { return this._dataChange.getValue(); }
652+
set data(data: TestData[]) { this._dataChange.next(data); }
653653

654654
constructor(public treeControl: TreeControl<TestData>) {
655655
super();

src/lib/tree/tree.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,8 @@ export class TestData {
435435
class FakeDataSource {
436436
dataIndex = 0;
437437
_dataChange = new BehaviorSubject<TestData[]>([]);
438-
set data(data: TestData[]) { this._dataChange.next(data); }
439438
get data() { return this._dataChange.getValue(); }
439+
set data(data: TestData[]) { this._dataChange.next(data); }
440440

441441
connect(): Observable<TestData[]> {
442442
return this._dataChange;

0 commit comments

Comments
 (0)