Skip to content

Commit 3447891

Browse files
authored
refactor: ensure typography mixins expect consistent arguments (#18738)
Currently we have a few components with typography mixins that do not match the majority of other components. These components have typography mixins where the `$config` is optional. We want to always require a config (similar to how it's done in other components) to avoid breaking changes in the future, and to have a consistent API.
1 parent 90e809e commit 3447891

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/material-experimental/mdc-checkbox/_checkbox-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
$mdc-checkbox-disabled-color: $orig-mdc-checkbox-disabled-color !global;
7171
}
7272

73-
@mixin mat-checkbox-typography-mdc($config: null) {
73+
@mixin mat-checkbox-typography-mdc($config) {
7474
@include mat-using-mdc-typography($config) {
7575
@include mdc-checkbox-without-ripple($query: $mat-typography-styles-query);
7676
@include mdc-form-field-core-styles($query: $mat-typography-styles-query);

src/material-experimental/mdc-list/_list-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
}
88
}
99

10-
@mixin mat-list-typography-mdc($config: null) {
10+
@mixin mat-list-typography-mdc($config) {
1111
@include mat-using-mdc-typography($config) {
1212
@include mdc-list-without-ripple($query: $mat-typography-styles-query);
1313
}

src/material-experimental/mdc-progress-bar/_progress-bar-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@
2828
}
2929
}
3030

31-
@mixin mat-progress-bar-typography-mdc($config: null) {
31+
@mixin mat-progress-bar-typography-mdc($config) {
3232
// No typography for this component.
3333
}

0 commit comments

Comments
 (0)