Skip to content

Commit 5d1643a

Browse files
CaerusKarujelbourn
authored andcommitted
fix(overlay): correct misspelled flexibleDiemsions property (#12927)
BREAKING CHANGE: The `flexibleDiemsions` property on `CdkConnectedOverlay` has been renamed to `flexibleDimensions` Fixes #12925
1 parent b62343a commit 5d1643a

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

src/cdk/overlay/overlay-directives.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,12 +382,12 @@ describe('Overlay directives', () => {
382382
});
383383

384384
it('should allow for flexible positioning to be enabled', () => {
385-
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).not.toBe(true);
385+
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).not.toBe(true);
386386

387387
fixture.componentInstance.flexibleDimensions = true;
388388
fixture.detectChanges();
389389

390-
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).toBe(true);
390+
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).toBe(true);
391391
});
392392

393393
it('should allow for growing after open to be enabled', () => {

src/cdk/overlay/overlay-directives.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,10 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
183183

184184
/** Whether the overlay's width and height can be constrained to fit within the viewport. */
185185
@Input('cdkConnectedOverlayFlexibleDimensions')
186-
get flexibleDiemsions() { return this._flexibleDimensions; }
187-
set flexibleDiemsions(value: boolean) { this._flexibleDimensions = coerceBooleanProperty(value); }
186+
get flexibleDimensions() { return this._flexibleDimensions; }
187+
set flexibleDimensions(value: boolean) {
188+
this._flexibleDimensions = coerceBooleanProperty(value);
189+
}
188190

189191
/** Whether the overlay can grow after the initial open when flexible positioning is turned on. */
190192
@Input('cdkConnectedOverlayGrowAfterOpen')
@@ -310,7 +312,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
310312
private _createPositionStrategy(): FlexibleConnectedPositionStrategy {
311313
const strategy = this._overlay.position()
312314
.flexibleConnectedTo(this.origin.elementRef)
313-
.withFlexibleDimensions(this.flexibleDiemsions)
315+
.withFlexibleDimensions(this.flexibleDimensions)
314316
.withPush(this.push)
315317
.withGrowAfterOpen(this.growAfterOpen)
316318
.withViewportMargin(this.viewportMargin)

src/lib/schematics/update/material/data/property-names.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,20 @@ export const propertyNames: VersionChanges<MaterialPropertyNameData> = {
352352
}
353353
}
354354
]
355+
},
356+
357+
// TODO(devversion): this should be part of the V6 to V7 upgrade
358+
{
359+
pr: 'https://github.com/angular/material2/pull/12927',
360+
changes: [
361+
{
362+
replace: 'flexibleDiemsions',
363+
replaceWith: 'flexibleDimensions',
364+
whitelist: {
365+
classes: ['CdkConnectedOverlay']
366+
}
367+
}
368+
]
355369
}
356370
]
357371
};

0 commit comments

Comments
 (0)