Skip to content

fix(overlay): fix typo in property name #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 14, 2018
Merged

Conversation

CaerusKaru
Copy link
Member

BREAKING CHANGE:

  • the flexibleDiemsions on CdkConnectedOverlay has been renamed to flexibleDimensions

Fixes #12925

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 31, 2018
@CaerusKaru CaerusKaru changed the title fix(overlay): fix type in property name fix(overlay): fix typo in property name Aug 31, 2018
@jelbourn
Copy link
Member

We'll need an ng update fix for this one; @CaerusKaru want to try making one?

@CaerusKaru
Copy link
Member Author

@jelbourn Sure, I can do that later today.

@CaerusKaru CaerusKaru requested a review from amcdnl as a code owner August 31, 2018 22:50
@CaerusKaru
Copy link
Member Author

@jelbourn should be all set

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn shouldn't we also keep the old name until the next major version?

@@ -335,5 +335,18 @@ export const propertyNames = transformChanges<MaterialPropertyNameData>([
}
}
]
},

{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment // TODO(devversion): this should be part of the V6 to V7 upgrade.

@jelbourn
Copy link
Member

jelbourn commented Sep 4, 2018

@crisbeto technically.................yeah. But nobody is using it in Google, and since it's such a blatant typo, I was going to let this one slide.

@CaerusKaru
Copy link
Member Author

@jelbourn et al sorry for the commit spam. I momentarily lost my mind trying to remove a modified package-lock from the commit. I was waiting on @jelbourn's sign-off re @crisbeto's point before adding @devversion's comment. This PR should be good to go 👍

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 11, 2018
@jelbourn jelbourn merged commit 5d1643a into angular:master Sep 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in cdk/overlay/overlay-directives.ts
5 participants