-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(overlay): fix typo in property name #12927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We'll need an |
@jelbourn Sure, I can do that later today. |
@jelbourn should be all set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn shouldn't we also keep the old name until the next major version?
@@ -335,5 +335,18 @@ export const propertyNames = transformChanges<MaterialPropertyNameData>([ | |||
} | |||
} | |||
] | |||
}, | |||
|
|||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment // TODO(devversion): this should be part of the V6 to V7 upgrade
.
@crisbeto technically.................yeah. But nobody is using it in Google, and since it's such a blatant typo, I was going to let this one slide. |
BREAKING CHANGE: * the `flexibleDiemsions` on `CdkConnectedOverlay` has been renamed to `flexibleDimensions` Fixes angular#12925
@jelbourn et al sorry for the commit spam. I momentarily lost my mind trying to remove a modified package-lock from the commit. I was waiting on @jelbourn's sign-off re @crisbeto's point before adding @devversion's comment. This PR should be good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
BREAKING CHANGE:
flexibleDiemsions
onCdkConnectedOverlay
has been renamed toflexibleDimensions
Fixes #12925