Skip to content

Commit 665e667

Browse files
devversionjelbourn
authored andcommitted
build: payload task fails if functions are down (#5217)
It can happen that the firebase `payloadGithubStatus` function is temporary disabled because a deploy failed (for example due to deploying while function executes). This leads to a failure inside of the payload CI task because the task is trying to parse the body using JSON (which is not always a JSON response) It's not worth trying to parse the JSON value since it's only used for debugging and to give an insight what's going on in the functions.
1 parent 39f22c2 commit 665e667

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/gulp/tasks/payload.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ async function updateGithubStatus(commitSha: string, packageName: string, packag
127127
if (err) {
128128
reject(`Dashboard Error ${err.toString()}`);
129129
} else {
130-
console.info('Dashboard Response:', JSON.parse(body).message);
130+
console.info(`Dashboard Response (${response.statusCode}): ${body}`);
131131
resolve(response.statusCode);
132132
}
133133
});

0 commit comments

Comments
 (0)