build: payload task fails if functions are down #5217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that the firebase `payloadGithubStatus` function is temporary disabled because a deploy failed (for example due to deploying while function executes). This leads to a failure inside of the payload CI task because the task is trying to parse the body using JSON (which is not always a JSON response) It's not worth trying to parse the JSON value since it's only used for debugging and to give an insight what's going on in the functions.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that the firebase
payloadGithubStatusfunction is temporary disabled because a deploy failed (for example due to deploying while function executes).This leads to a failure inside of the payload CI task because the task is trying to parse the body using JSON (which is not always a JSON response)
It's not worth trying to parse the JSON value since it's only used for debugging and to give an insight what's going on in the functions.
Note: As mentioned we can also try to parse the JSON if it's a json, but this doesn't really have any big benefits and it feels nicer to print the whole JSON which is readable already.