Skip to content

Commit 7fc4336

Browse files
committed
build: fix dev-app preview action permissions (#25206)
We have changed the default permissions for Github actions as it seems, and the PR comment cannot be created in actions without having the necessary write permission. This commit fixes this. (cherry picked from commit f66e7ad)
1 parent f85330a commit 7fc4336

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

.github/workflows/build-dev-app.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ on:
1111
pull_request:
1212
types: [synchronize, labeled]
1313

14+
permissions: read-all
15+
1416
jobs:
1517
dev-app-build:
1618
runs-on: ubuntu-latest

.github/workflows/deploy-dev-app.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,13 @@ name: Deploying dev-app to Firebase previews
99

1010
on:
1111
workflow_run:
12-
workflows: [Build dev-app for deployment]
12+
workflows: ['Build dev-app for deployment']
1313
types: [completed]
1414

15+
permissions:
16+
# Needed in order to be able to comment on the pull request.
17+
pull-requests: write
18+
1519
jobs:
1620
deploy-dev-app:
1721
runs-on: ubuntu-latest

.github/workflows/lock-closed.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ on:
55
# Run at 00:00 every day
66
- cron: '0 0 * * *'
77

8+
permissions: read-all
9+
810
jobs:
911
lock_closed:
1012
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)