Skip to content

Commit 88089a7

Browse files
devversionkara
authored andcommitted
build: remove url from payload status (#5092)
1 parent b3c75bb commit 88089a7

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

tools/dashboard/functions/github/github-status.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export type GithubStatusData = {
1111
result: boolean;
1212
name: string;
1313
description: string;
14-
url: string;
14+
url?: string;
1515
};
1616

1717
/** Function that sets a Github commit status */

tools/dashboard/functions/payload-github-status.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {setGithubStatus} from './github/github-status';
55
export const payloadGithubStatus = https.onRequest(async (request, response) => {
66
const authToken = request.header('auth-token');
77
const commitSha = request.header('commit-sha');
8-
const payloadDiff = parseInt(request.header('commit-payload-diff'));
8+
const payloadDiff = parseFloat(request.header('commit-payload-diff'));
99

1010
if (!verifyToken(authToken)) {
1111
return response.status(403).json({message: 'Auth token is not valid'});
@@ -22,8 +22,7 @@ export const payloadGithubStatus = https.onRequest(async (request, response) =>
2222
await setGithubStatus(commitSha, {
2323
result: true,
2424
name: 'Library Payload',
25-
url: `https://travis-ci.org/angular/material2/jobs/${process.env['TRAVIS_JOB_ID']}`,
26-
description: `${payloadDiff > 0 ? `+` : ''} ${payloadDiff.toFixed(2)}KB`
25+
description: `${payloadDiff >= 0 ? `+` : ''}${payloadDiff.toFixed(2)}KB`
2726
});
2827

2928
response.json({message: 'Payload Github status successfully set.'});

0 commit comments

Comments
 (0)