Skip to content

build: remove url from payload status #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2017
Merged

build: remove url from payload status #5092

merged 3 commits into from
Jun 12, 2017

Conversation

devversion
Copy link
Member

  • Removes the invalid URL that will be shown in the payload status
  • If the payload difference is zero there should be a plus instead of the plain number (Keeping the message simple for now. No need to construct complex descriptions)

@devversion
build: remove url from payload status
50ecc4b 
* Removes the invalid URL that will be shown in the payload status
* If the payload difference is zero there should be a plus instead of the plain number (Keeping the message simple for now. No need to construct complex descriptions)
@devversion devversion requested a review from jelbourn June 12, 2017 19:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 12, 2017
jelbourn
jelbourn approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 12, 2017
@devversion
Copy link
Member Author

Also fixed that the payload difference will be rounded.

@kara kara merged commit 88089a7 into angular:master Jun 12, 2017
@devversion devversion deleted the build/no-url-payload-diff branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @kara @googlebot