Skip to content

Commit a1762cc

Browse files
devversionandrewseguin
authored andcommitted
build: bazel not working on windows workaround (#15484)
Recently we updated our Bazel setup to Angular V8 beta. With that change the Sass dependencies took precedence and now fetch the skylib repository using the `git_repository` bazel rule. Unfortunately this rule does not always work as expected in Windows (e.g. when used within Git Bash). Until Bazel drops the dependency on bash, we should make sure that we fetch skylib through the `http_archive` rule (which works on windows). Skylib will be transitively brought in by the `rules_webtesting` repository.
1 parent 59e26f6 commit a1762cc

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

WORKSPACE

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,6 @@ ts_setup_workspace()
5252
load("@npm_bazel_karma//:package.bzl", "rules_karma_dependencies")
5353
rules_karma_dependencies()
5454

55-
# Fetch transitive dependencies which are needed to use the Sass rules.
56-
load("@io_bazel_rules_sass//:package.bzl", "rules_sass_dependencies")
57-
rules_sass_dependencies()
58-
59-
# Setup the Sass rule repositories.
60-
load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")
61-
sass_repositories()
62-
6355
# Setup web testing. We need to setup a browser because the web testing rules for TypeScript need
6456
# a reference to a registered browser (ideally that's a hermetic version of a browser)
6557
load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")
@@ -68,6 +60,14 @@ web_test_repositories()
6860
load("@npm_bazel_karma//:browser_repositories.bzl", "browser_repositories")
6961
browser_repositories()
7062

63+
# Fetch transitive dependencies which are needed to use the Sass rules.
64+
load("@io_bazel_rules_sass//:package.bzl", "rules_sass_dependencies")
65+
rules_sass_dependencies()
66+
67+
# Setup the Sass rule repositories.
68+
load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")
69+
sass_repositories()
70+
7171
# Temporarily add Angular sources and its dependencies to consume the ts_api_guardian,
7272
# remote-build-execution, and protractor stuff.
7373
# TODO(jelbourn): remove this once we can do all the same stuff via @npm//@angular

0 commit comments

Comments
 (0)