build: bazel not working on windows workaround #15484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we updated our Bazel setup to Angular V8 beta. With that change the Sass dependencies took precedence and now fetch the skylib repository using the `git_repository` bazel rule. Unfortunately this rule does not always work as expected in Windows (e.g. when used within Git Bash). Until Bazel drops the dependency on bash, we should make sure that we fetch skylib through the `http_archive` rule (which works on windows). Skylib will be transitively brought in by the `rules_webtesting` repository.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we updated our Bazel setup to Angular V8 beta. With that change
the Sass dependencies took precedence and now fetch the skylib repository
using the
git_repositorybazel rule. Unfortunately this rule does not alwayswork as expected in Windows (e.g. when used within Git Bash). Until Bazel
drops the dependency on bash, we should make sure that we fetch skylib
through the
http_archiverule (which works on windows). Skylib will betransitively brought in by the
rules_webtestingrepository.